Repository navigation
chore(deps): update dependency typescript to v7 - #26
Open
renovate[bot] wants to merge 1 commit into
Open
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
August 13, 2026 04:58
7795bae to
f8558ce
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
August 14, 2026 18:59
f8558ce to
d534cce
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
August 19, 2026 23:51
d534cce to
a7547ce
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
2 times, most recently
from
August 27, 2026 00:06
d26e606 to
92624e6
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
August 28, 2026 17:14
92624e6 to
2578f4c
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
2 times, most recently
from
September 3, 2026 02:02
93e5bc2 to
1062593
Compare
This was referenced Sep 3, 2026
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
September 7, 2026 23:08
1062593 to
780abcf
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
2 times, most recently
from
September 10, 2026 03:08
7891022 to
000d608
Compare
This was referenced Sep 10, 2026
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
September 15, 2026 13:18
000d608 to
79ad3f6
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
September 24, 2026 05:59
79ad3f6 to
22886f4
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
October 1, 2026 14:06
22886f4 to
405b551
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
October 1, 2026 14:12
405b551 to
1a5d00f
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
October 5, 2026 20:28
1a5d00f to
717a34c
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
October 7, 2026 19:52
717a34c to
7ece377
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
October 13, 2026 19:22
7ece377 to
db10281
Compare
renovate
Bot
force-pushed
the
renovate/typescript-7.x
branch
from
October 17, 2026 10:05
db10281 to
22b8947
Compare
There was a problem hiding this comment.
❌ Some changes need to be made — same ERESOLVE blocker reproduces on the 2026-10-17 rebase
- ❌ P0 —
typescript-eslint@^8.70.0 on main still peers typescript@">=4.8.4 <6.1.0"; TS ^7.0.2 violates that range, Renovate re-ran its artifact job today at 2026-10-17T10:05:21Z and the ERESOLVE log is unchanged, so npm cannot regenerate package-lock.json → npm ci will fail on every CI job after merge (lint, typecheck, test, build, e2e). Full repro + three unblock paths in the inline comment on package.json:54.
- ✅ Diff itself (
^6.0.3 → ^7.0.2 on package.json:54) is well-scoped and uses ^ consistent with every other devDependency.
- ❔ Should the shared
nsheaps/renovate-config add a packageRules grouping for typescript + typescript-eslint + @typescript-eslint/**, so this PR stops getting rebased byte-identically on every weekly Renovate run? This is now the 10th such review in ~9 weeks, all finding the same ERESOLVE and recommending the same hold.
Click to expand for full details
ERESOLVE blocker reproduces on the 2026-10-17 rebasetypescript-eslint@^8.70.0 on main still peers typescript@">=4.8.4 <6.1.0"; TS ^7.0.2 violates that range, Renovate re-ran its artifact job today at 2026-10-17T10:05:21Z and the ERESOLVE log is unchanged, so npm cannot regenerate package-lock.json → npm ci will fail on every CI job after merge (lint, typecheck, test, build, e2e). Full repro + three unblock paths in the inline comment on package.json:54.^6.0.3 → ^7.0.2 on package.json:54) is well-scoped and uses ^ consistent with every other devDependency.nsheaps/renovate-config add a packageRules grouping for typescript + typescript-eslint + @typescript-eslint/**, so this PR stops getting rebased byte-identically on every weekly Renovate run? This is now the 10th such review in ~9 weeks, all finding the same ERESOLVE and recommending the same hold.How I arrived at this
- Fetched PR state — new head
22b8947(rebased 2026-10-17T10:05:13Z),+1/-1acrosspackage.jsononly. Nopackage-lock.jsonupdate in the diff. - Fetched Renovate's artifact-update comment (comment 5261781302) — timestamp refreshed to 2026-10-17T10:05:21Z by Renovate's weekly re-run; body still contains the full
ERESOLVElog (peer typescript: ">=4.8.4 <6.1.0"from every@typescript-eslint/*@8.70.0subpackage, foundtypescript@7.0.2). Reproduced on the live inline thread onpackage.json:54. - Read
package.jsonat head22b8947—typescript-eslint: ^8.70.0, same asmain(unchanged since my 2026-10-07 review). No coordinated bump landed. - Checked upstream
typescript-eslint— latest TS-7-relevant note remains8.65.0's #12529, which only warns when TS 7 is detected without widening the peer range. No peer-range widening through8.70.0. - Checked
renovate.json— extendslocal>nsheaps/renovate-config; nopackageRulesin this repo, so a TS/typescript-eslint grouping (if added) would need to live in that shared config. - Verdict — merging as-is breaks
npm cifor every workflow that installs deps. This is the 10th review with the exact same finding; the delta each time is only the rebased SHA and whatevertypescript-eslintpatch landed onmain.
Scoring rationale
- Quality 85 — the diff is minimal and correct in intent; the ecosystem simply can't currently resolve it. No code-level smell to flag.
- Security N/A — pure dev-dep version bump, no runtime surface area change.
- Simplicity 95 — one-line change; nothing to simplify.
- Confidence 98 — Renovate's own
npmlog, re-run today, is the ground truth onERESOLVE.
Thread hygiene
- All 10 prior CHANGES_REQUESTED reviews minimized as
OUTDATEDjust before submitting this one. - All 8 previous byte-nearly-identical inline comments on
package.json:54remain minimized asOUTDATED. - The 2026-10-13 inline comment on
package.json:54was updated in place (not duplicated) with an**Edit (2026-10-17):**section reflecting the new head22b8947, so the live thread shows exactly one current finding instead of a 10th near-duplicate.
Repo-convention checks
- ✅
package.json:54keeps the^range convention consistent with every other devDependency. - ✅ No
any/@ts-ignoreintroduced (CLAUDE.md line 34). Option #3 in the inline comment explicitly rejects softening strictness as a workaround. - ❌ No
package-lock.jsonupdate accompanies thepackage.jsonchange — mandatory for an npm-managed repo withnpm ciin CI.
Follow-ups
- P0 — Hold or close this PR until
typescript-eslintpublishes a release whose peer range includes TS 7, then bump both together (see inline comment onpackage.json:54for the three concrete unblock paths). - P2 — Add a Renovate
packageRulesgrouping fortypescript+typescript-eslint+@typescript-eslint/**innsheaps/renovate-configso this PR doesn't resurface on every weekly rebase (and so a future TS major bump arrives as one coordinated PR with the compatible linter release).
Follow-ups:
- P0: Hold or close this PR; do not merge until
typescript-eslintships a release whose peer range includes TypeScript 7. - P2: Group
typescript+typescript-eslint+@typescript-eslint/**in the shared Renovate config to prevent re-opening this broken PR on every rebase.
References
- Workflow run: https://github.com/nsheaps/.ai-agent-henry/actions/runs/39023574757/attempts/1
- Renovate ERESOLVE log (artifact-update), refreshed 2026-10-17T10:05:21Z: #26 (comment)
typescript-eslint@8.65.0CHANGELOG (adds TS-7 detection warning, does NOT widen peer range): https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-eslint/CHANGELOG.md#8650-2026-07-20typescript-eslint#12529("add warning when TS 7 is detected"): typescript-eslint/typescript-eslint#12529- Repo coding conventions: https://github.com/nsheaps/private-pages/blob/main/CLAUDE.md#L34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^6.0.3→^7.0.2Release Notes
microsoft/TypeScript (typescript)
v7.0.2Compare Source
Configuration
📅 Schedule: (in timezone America/New_York)
🚦 Automerge: Disabled because a matching PR was automerged previously.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.